Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for new release #304

Closed
UebelAndre opened this issue Nov 23, 2020 · 6 comments
Closed

Request for new release #304

UebelAndre opened this issue Nov 23, 2020 · 6 comments

Comments

@UebelAndre
Copy link
Collaborator

I think given recent changes a new release should be made. However, I'd really like it if the release could be made after #303 is merged. Additionally, there are a few PRs before it and there are some other PRs in work that might be worth including as well. But that's up to the code owners (obviously) 😄
@UebelAndre UebelAndre mentioned this issue Nov 25, 2020
Merged
@UebelAndre UebelAndre mentioned this issue Dec 8, 2020
Closed
@UebelAndre
Copy link
Collaborator Author

The PR linked in this issue has been merged and I feel the changes I made to the repo should be in a decent spot for a release. That said though, I've opened up #319 which I feel really completes the UX for cargo workspace support and it'd be nice to have that be the first user experience

@UebelAndre
Copy link
Collaborator Author

@acmcarther Up to you though. I would otherwise have 3 PRs (including #319) I'd like to get through for a release. #319 being the largest of the 3.

@UebelAndre
Copy link
Collaborator Author

@acmcarther Actually, I think a release now would be best since it'd unblock some efforts in rules_rust.

@acmcarther
Copy link
Member

acmcarther commented Dec 18, 2020 •
edited
Loading 

./publish-new-version.sh 0.8.0

Edit: Done

@UebelAndre
Copy link
Collaborator Author

Thank you!

@UebelAndre
Copy link
Collaborator Author

Gonna close this for now to make it cleaner as to what went into this. I'll open a new request when I think a new release is ready.

@UebelAndre UebelAndre mentioned this issue Dec 18, 2020
Closed
damienmg pushed a commit to bazelbuild/rules_rust that referenced this issue Jan 27, 2021
@UebelAndre
Renamed workspace name from io_bazel_rule_rust to rules_rust (#500)
1fe2315 
Generated by running
```bash
LANG=C sed -i '' -e 's/io_bazel_rules_rust/rules_rust/' $(find . -type f -not -path "./.git/*")
```

There's some small amount of sorting in here as well (based on the new name)

Closes #499

Blocked by google/cargo-raze#298 and google/cargo-raze#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acmcarther @UebelAndre