Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deprecation warnings #303

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Added deprecation warnings #303

merged 5 commits into from
Dec 16, 2020

Conversation

UebelAndre
Copy link
Collaborator

This flags certain settings as deprecated. Namely:

Blocked by #302

@UebelAndre UebelAndre mentioned this pull request Nov 23, 2020
Closed
@UebelAndre UebelAndre mentioned this pull request Dec 4, 2020
Closed
4ldas
4ldas approved these changes Dec 9, 2020
View reviewed changes
Copy link

@4ldas 4ldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

@UebelAndre UebelAndre changed the title Deprecations Added deprecation warnings Dec 10, 2020
UebelAndre
UebelAndre commented Dec 14, 2020
View reviewed changes
impl/src/settings.rs Outdated
|| self.vendor_dir.is_some()
}

fn print_deprecation_warnings(&self) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation warnings have been added here

@UebelAndre UebelAndre marked this pull request as ready for review December 15, 2020 04:13
@UebelAndre
Copy link
Collaborator Author

@acmcarther This PR is now ready for review

acmcarther
acmcarther requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@acmcarther acmcarther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of nits I don't feel strongly about.

impl/src/settings.rs Outdated Show resolved Hide resolved
impl/src/settings.rs Outdated Show resolved Hide resolved
impl/src/settings.rs Outdated Show resolved Hide resolved
impl/src/settings.rs Show resolved Hide resolved
@UebelAndre
Copy link
Collaborator Author

@acmcarther Ready for another review

acmcarther
acmcarther approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@acmcarther acmcarther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acmcarther acmcarther merged commit 3515a09 into google:master Dec 16, 2020
@UebelAndre UebelAndre deleted the deprecations branch December 16, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ldas 4ldas 4ldas approved these changes

@acmcarther acmcarther acmcarther approved these changes

@damienmg damienmg Awaiting requested review from damienmg

@dfreese dfreese Awaiting requested review from dfreese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UebelAndre @acmcarther @4ldas