-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flipped default of incompatible_relative_workspace_path
to true
#204
Conversation
Now that there's be some kind of release (see #216) I think a change like this could be merged. It doesn't have to be immediately (especially given that there doesn't seem to have been any release notes informing people of the change) but I do think this could be merged and a notice posted somewhere to give users a chance to prep for the migration. |
What does this mean for users that have their Cargo.toml in |
This means
Given the structure above, you can currently run Setting |
I don't really understand the change that motivated the original flag. My concern is "will changing this default break existing users". Or, "do users using the old model need to be made aware of this change-in-defaults" so that they can do something. |
To the best of my knowledge, feature this flag toggles would not have broken existing behavior. The only case where it might have would be if users ran raze using |
So to be clear, no I don't believe this change will break existing users. |
Alright, sgtm. |
@acmcarther Can you release a patch release for this? |
This is a followup of #185 where an incompatibility flag was added that gates the new behavior introduced there in an effort to avoid a breaking change for current users.
However, I feel given enough time, the incompatibility flag can be removed and the forked behavior can be cleaned up. This is just a change to the default so users may have the more intuitive behavior and users still reliant on the previous behavior can flip the
incompatible_relative_workspace_path
setting to restore it.This change will likely require an update to the root
README.md
. I would love some thoughts on how this could best be rolled out and what specifically people think should be updated in theREADME.md
file.