Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese (Traditional) translation #684

Open
mgeisler opened this issue May 25, 2023 · 15 comments
Open

Chinese (Traditional) translation #684

mgeisler opened this issue May 25, 2023 · 15 comments

Comments

@mgeisler
Copy link
Collaborator

mgeisler commented May 25, 2023

Discuss a Chinese (Traditional) translation (zh-TW) of the course. For reference, here is a translation of the Rust Book: https://github.com/rust-tw/book-tw.

For the Chinese (Simplified) translation, please see #324.

This was referenced May 25, 2023
@mgeisler
Copy link
Collaborator Author

Just like for Chinese (Simplified), I suggest coordinating the work on this translation via a spreadsheet.

  1. First, we need someone to put up a PR to get a zh-Hant.po file committed
  2. After that, use this spreadsheet to coordinate.
    • Please add yourself on the first page!
    • Pick a file from the second sheet and add your Github username next to it to claim it.
      • Change the state to "In progress" and
      • Add today's date to the last change column.
    • The spreadsheet is editable by everybody (both inside and outside of Google) so you can add/remove things, comment on it and generally update it to suit your needs.

Please send small PRs! I suggest translating the titles in the SUMMARY.md file as you translate the content itself, but that will naturally lead to contention on that file. Perhaps you want to instead agree upfront about the wording for the titles? Our discussions would be a good place to do this.

See #683 for a just-started discussion about where to coordinate a translation table. You might want to create a similar table — in the spreadsheet, in the PO file directly, or in a discussion post.

Let me know if I've forgotten something or can help in any other way!

@mgeisler
Copy link
Collaborator Author

Hi all, we need someone to put up an empty (or nearly empty) po/zh-Hant.po file using the translation instructions.

Please let me know if you run into any trouble with this!

mgeisler added a commit that referenced this issue May 26, 2023
@mgeisler mgeisler linked a pull request May 26, 2023 that will close this issue
@mgeisler mgeisler removed a link to a pull request May 26, 2023
@mgeisler
Copy link
Collaborator Author

Hi all, we need someone to put up an empty (or nearly empty) po/zh-Hant.po file using the translation instructions.

Please let me know if you run into any trouble with this!

I went ahead and created #697 for this since I already have everything setup locally.

@hueich
Copy link
Collaborator

hueich commented May 26, 2023

Thanks for getting this started!

mgeisler added a commit that referenced this issue May 26, 2023
@mgeisler
Copy link
Collaborator Author

Thanks for getting this started!

Thanks for the review on #697! You have an eye for detail and I invite you to add yourself to CODEOWNERS if you're interested in reviewing more changes 😄

@hueich
Copy link
Collaborator

hueich commented May 26, 2023

Sent #702

@edong
Copy link
Collaborator

edong commented May 29, 2023

Hello fellow contributors, I've added a tab to the spreadsheet to take a first stab at coming up with a terminology list with translations.

I think it often makes sense to include the English term in parentheses when first using a Chinese term.

@mgeisler
Copy link
Collaborator Author

mgeisler commented Jun 1, 2023

Hi all,

I've talked more with people at Google about the naming of the translation and it turns out I was wrong in recommending zh-Hant here. The vocabulary is different between Taiwan and Hong Kong, even though they both use Traditional Chinese script.

So I will like us to rename the po/zh-Hant.po file to po/zh-TW.po. @edong, you were the one who made me aware of the differences... would you be up for sending a PR to rename the file?

Also, I recently added a list of incomplete translations. Let me know when you want to mention the translation there — I would suggest doing so after translating the first few pages.

mingyc added a commit to mingyc/comprehensive-rust that referenced this issue Jun 2, 2023
As mentioned in google#684 (comment), Traditional Chinese are used differently in HK and TW. The intention for zh-Hant.go was to cover zh-TW.
mingyc added a commit to mingyc/comprehensive-rust that referenced this issue Jun 2, 2023
- Add myself as the code reviewer for zh-TW, as I am already listed in
  [the
  sheet](https://docs.google.com/spreadsheets/d/1bVSJEUGkI9gcqmmA4va4y-I7LzgQUqNwnZYJsQNMBGE/edit#gid=0) for zh-Hant translation
- As mentioned in
google#684 (comment), Traditional Chinese are used differently in HK and TW. The intention for zh-Hant.go was to cover zh-TW.
@mingyc
Copy link
Collaborator

mingyc commented Jun 2, 2023

Sent out #757 to rename zh-Hant.po to zh-TW.po

mingyc added a commit that referenced this issue Jun 2, 2023
- Add myself as the code reviewer for zh-TW, as I am already listed in
  [the
  sheet](https://docs.google.com/spreadsheets/d/1bVSJEUGkI9gcqmmA4va4y-I7LzgQUqNwnZYJsQNMBGE/edit#gid=0) for zh-Hant translation
- As mentioned in
#684 (comment), Traditional Chinese are used differently in HK and TW. The intention for zh-Hant.go was to cover zh-TW.
henrif75 added a commit that referenced this issue Oct 20, 2023
Professional translations for missing day 3 entries #684
henrif75 added a commit that referenced this issue Oct 22, 2023
Professional translations for missing day 2 entries #684


---------

Co-authored-by: Martin Geisler <martin@geisler.net>
Co-authored-by: Emma Li <liyu1204@gmail.com>
henrif75 added a commit that referenced this issue Oct 22, 2023
Professional translations for missing day 1 entries #684

---------

Co-authored-by: Victor Hsieh <victorhsieh@gmail.com>
henrif75 added a commit to henrif75/comprehensive-rust that referenced this issue Oct 22, 2023
Graduates the Chinese Simplified translation to the language drop-down selector. Part of Chinese (Traditional) translation google#684
henrif75 added a commit that referenced this issue Oct 23, 2023
Graduates the Chinese Traditional translation to the language drop-down
selector.
Part of Chinese (Traditional) translation #684.

File stats (Rust Fundamentals):

```
msggrep -v --location=src/{exercises/,}{android,bare-metal,concurrency,async}{.md,"/*","/*/*","/*/*/*"} po/zh-CN.po | msgfmt -o /dev/null --statistics -

1315 translated messages, 146 fuzzy translations, 149 untranslated messages.
```
@mgeisler
Copy link
Collaborator Author

mgeisler commented Jan 2, 2024

Hey folks, just a heads up that we're tinkering with publishing the course as a PDF — including for the translations: #1572.

If you have input on the font to use, please let us know!

@henrif75
Copy link
Collaborator

The untranslated content from v2 was sent to the translation service.

henrif75 added a commit that referenced this issue Mar 8, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Victor Hsieh <victorhsieh@gmail.com>
henrif75 added a commit that referenced this issue Mar 12, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <itsmings@gmail.com>
henrif75 added a commit that referenced this issue Mar 13, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <itsmings@gmail.com>
henrif75 added a commit that referenced this issue Mar 14, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Jonathan Hao <johnathan79717@gmail.com>
henrif75 added a commit that referenced this issue Mar 22, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <itsmings@gmail.com>
henrif75 added a commit that referenced this issue Apr 3, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <itsmings@gmail.com>
mingyc added a commit that referenced this issue Apr 5, 2024
#684

---------

Co-authored-by: Jonathan Hao <johnathan79717@gmail.com>
@henrif75
Copy link
Collaborator

I'm going to merge the content that was already been translated to v.2 (Day 1 until Android) and start helping users, while we're waiting for the Bare Metal and Concurrency sections.

henrif75 added a commit that referenced this issue May 3, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Jonathan Hao <johnathan79717@gmail.com>
henrif75 added a commit that referenced this issue May 7, 2024
…nto main (#2037)

This PR merges the Chinese Traditional (zh-TW) CR v.2 translation back
to main.
This requires just a syntactical review, as the partial PRs into this
branch were reviewed already.

You can skim this PR with the [GitHub CLI](https://cli.github.com/):

gh pr diff 2037 | bat -l patch

#1463 #684

---------

Co-authored-by: Victor Hsieh <victorhsieh@gmail.com>
Co-authored-by: Ming-Ying Chung <itsmings@gmail.com>
Co-authored-by: Jonathan Hao <johnathan79717@gmail.com>
henrif75 added a commit that referenced this issue May 15, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Jonathan Hao <johnathan79717@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants