Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync src/ with date in PO file when publishing #1243

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

mgeisler
Copy link
Collaborator

This will freeze translation in place: they will keep using the same English Markdown source files as the starting point until a new POT file is merged into the translation.

We still update all the files around the Markdown files: this allows us to fix things in the theme, for example.

Part of google/mdbook-i18n-helpers#16. The logic here should eventually be moved to somewhere in mdbook-i18n-helpers, most likely to the renderer that @sakex is building in google/mdbook-i18n-helpers#84.

@mgeisler
Copy link
Collaborator Author

Hi @sakex, I would like to have this PR merged ahead of google/mdbook-i18n-helpers#84 — it will stop the bleeding of us constantly invalidating the work done by our translators.

As I write in the PR description, you should be able to implement the same logic in google/mdbook-i18n-helpers#84 (and do it more robustly and cleanly since you can part the PO file more easily than my shell script).

@mgeisler mgeisler merged commit ca966f3 into main Sep 25, 2023
33 checks passed
@mgeisler mgeisler deleted the snapshot-publishing branch September 25, 2023 07:52
@mgeisler
Copy link
Collaborator Author

@henrif75, this change will have (good) implications for the translations. Translators will be able to freeze the English source files used when publishing the translation.

This means that they will effectively be working on a snapshot of the course — the snapshot is found based on the POT-Creation-Date header found in each PO file. This header is updated by msgmerge and it will soon be generated by mdbook-xgettext: google/mdbook-i18n-helpers#87.

I will write this up in our translation documentation as well.

mgeisler added a commit that referenced this pull request Oct 6, 2023
I don’t know if this is enough on its own? In principle, the new
publication system should work smoothly without people having to know
much about this header, so that’s why I only describe it briefly.

Followup to #1243.
mgeisler added a commit that referenced this pull request Oct 7, 2023
I don’t know if this is enough on its own? In principle, the new
publication system should work smoothly without people having to know
much about this header, so that’s why I only describe it briefly.

Followup to #1243.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants