-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync src/
with date in PO file when publishing
#1243
Conversation
1f96163
to
c807246
Compare
92fe9f6
to
9a856b1
Compare
72cf9cc
to
3180090
Compare
Hi @sakex, I would like to have this PR merged ahead of google/mdbook-i18n-helpers#84 — it will stop the bleeding of us constantly invalidating the work done by our translators. As I write in the PR description, you should be able to implement the same logic in google/mdbook-i18n-helpers#84 (and do it more robustly and cleanly since you can part the PO file more easily than my shell script). |
@henrif75, this change will have (good) implications for the translations. Translators will be able to freeze the English source files used when publishing the translation. This means that they will effectively be working on a snapshot of the course — the snapshot is found based on the I will write this up in our translation documentation as well. |
I don’t know if this is enough on its own? In principle, the new publication system should work smoothly without people having to know much about this header, so that’s why I only describe it briefly. Followup to #1243.
I don’t know if this is enough on its own? In principle, the new publication system should work smoothly without people having to know much about this header, so that’s why I only describe it briefly. Followup to #1243.
This will freeze translation in place: they will keep using the same English Markdown source files as the starting point until a new POT file is merged into the translation.
We still update all the files around the Markdown files: this allows us to fix things in the theme, for example.
Part of google/mdbook-i18n-helpers#16. The logic here should eventually be moved to somewhere in mdbook-i18n-helpers, most likely to the renderer that @sakex is building in google/mdbook-i18n-helpers#84.