Reduce the number of measure calls for children of Flexbox #514
+73
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prevents the number of measure calls for the children of the Flexbox. If any items in a FlexLine don't have the flexGrow or flexShrink attributes set, the children in the FlexLine don't have to be measured in the FlexboxHelper#determineMainSize method. Similarly, if the AlignItems attribute for the Flexbox is not equal to AlignItems.STRETCH nor any items in a FlexLine don't have the AlignSelf.STRETCH attributes, the items in the FlexLine don't have to be measured in the FlexboxHelpers#stretchViews method. Also this PR changes the default values of FlexboxLayout as follows: - mAlignItems: STRETCH -> FLEX_START - mAlignContent: STRETCH -> FLEX_START
thagikura
changed the title
If the temporary calculated line length is less than the length of the main axis, the calculation isn't needed.
yaraki
reviewed
Oct 31, 2019
| @@ -223,8 +223,8 @@ public FlexboxLayout(Context context, AttributeSet attrs, int defStyleAttr) { | |||
| mFlexWrap = a.getInt(R.styleable.FlexboxLayout_flexWrap, FlexWrap.NOWRAP); | |||
| mJustifyContent = a | |||
| .getInt(R.styleable.FlexboxLayout_justifyContent, JustifyContent.FLEX_START); | |||
| mAlignItems = a.getInt(R.styleable.FlexboxLayout_alignItems, AlignItems.STRETCH); | |||
| mAlignContent = a.getInt(R.styleable.FlexboxLayout_alignContent, AlignContent.STRETCH); | |||
| mAlignItems = a.getInt(R.styleable.FlexboxLayout_alignItems, AlignItems.FLEX_START); | |||
There was a problem hiding this comment.
Can this break existing apps? Should we bump up the major version if so?
There was a problem hiding this comment.
Yes, it may break the existing apps and we should bump the major version once we release it.
I think it's better in the long run because setting the AlignItems.STRETCH is expensive like setting the weight attribute in LinearLayout especially FlexboxLayout is nested more than several levels.
yaraki
approved these changes
Oct 31, 2019
|
Can you please mention the changes to default values in |
|
Sure. I'll update the README as well. Thanks for pointing it out.
2019年11月13日(水) 11:08 Artem Tyurin <notifications@github.com>:
… Can you please mention the changes to default values in Known differences
from the original CSS specification in README?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#514?email_source=notifications&email_token=AAGCNSI4HS4W5R2RN2OANLTQTNOQZA5CNFSM4JERALVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4TWFI#issuecomment-553204501>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGCNSPBXT373TCDZ4ITOGLQTNOQZANCNFSM4JERALVA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of measure calls for the children of the
Flexbox.
If any items in a FlexLine don't have the flexGrow or flexShrink
attributes set, the children in the FlexLine don't have to be measured
in the FlexboxHelper#determineMainSize method.
Similarly, if the AlignItems attribute for the Flexbox is not equal to
AlignItems.STRETCH nor any items in a FlexLine don't have the
AlignSelf.STRETCH attributes, the items in the FlexLine don't have to be
measured in the FlexboxHelpers#stretchViews method.
Also this PR changes the default values of FlexboxLayout as follows:
Fixes #46