Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of measure calls for children of Flexbox #514

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Commits on Oct 24, 2019

  1. WIP: Attempt to fix #46

    This PR prevents the number of measure calls for the children of the
    Flexbox.
    If any items in a FlexLine don't have the flexGrow or flexShrink
    attributes set, the children in the FlexLine don't have to be measured
    in the FlexboxHelper#determineMainSize method.
    
    Similarly, if the AlignItems attribute for the Flexbox is not equal to
    AlignItems.STRETCH nor any items in a FlexLine don't have the
    AlignSelf.STRETCH attributes, the items in the FlexLine don't have to be
    measured in the FlexboxHelpers#stretchViews method.
    
    Also this PR changes the default values of FlexboxLayout as follows:
    - mAlignItems: STRETCH -> FLEX_START
    - mAlignContent: STRETCH -> FLEX_START
    thagikura committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    ca711f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Try to fix the failed tests

    thagikura committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    2bbf924 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Some clean ups

    thagikura committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    118366a View commit details
    Browse the repository at this point in the history
  2. Prevents the calculation of shrinking flex lines.

    If the temporary calculated line length is less than the length of the
    main axis, the calculation isn't needed.
    thagikura committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    4aa0c13 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c3aaf2 View commit details
    Browse the repository at this point in the history