Added fixed log name support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it |
|
CLAs look good, thanks! |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
See https://code.google.com/p/google-glog/issues/detail?id=209 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk.
|
CLAs look good, thanks! |
3 tasks
hiendsoft
approved these changes
May 24, 2018
|
Can we get this merged? |
This was referenced Nov 1, 2019
|
I'm reverting this PR due to CI failures. Please revise and resubmit. |
ezegomez
pushed a commit
to ezegomez/glog
that referenced
this pull request
Nov 4, 2019
See https://code.google.com/p/google-glog/issues/detail?id=209 and former google#19 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk.
sergiud
pushed a commit
that referenced
this pull request
Nov 6, 2019
* Added fixed log name support, take 2 See https://code.google.com/p/google-glog/issues/detail?id=209 and former #19 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk. * Ifdef away fcntl on mingw * Use the defined HAVE_FCNTL instead * ifdef away tests as well add have_sys_wait for wait() on mingw. * OS_WINDOWS bug in fseeking to the end, only triggered here
Merged
nathanhjli
pushed a commit
to nathanhjli/glog
that referenced
this pull request
Jan 20, 2022
* Added fixed log name support, take 2 See https://code.google.com/p/google-glog/issues/detail?id=209 and former google#19 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk. * Ifdef away fcntl on mingw * Use the defined HAVE_FCNTL instead * ifdef away tests as well add have_sys_wait for wait() on mingw. * OS_WINDOWS bug in fseeking to the end, only triggered here
nathanhjli
pushed a commit
to nathanhjli/glog
that referenced
this pull request
Jan 20, 2022
…8d7f87 * Added fixed log name support, take 2 See https://code.google.com/p/google-glog/issues/detail?id=209 and former google#19 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk. * Ifdef away fcntl on mingw * Use the defined HAVE_FCNTL instead * ifdef away tests as well add have_sys_wait for wait() on mingw. * OS_WINDOWS bug in fseeking to the end, only triggered here
nathanhjli
added a commit
to yugabyte/glog
that referenced
this pull request
Jan 20, 2022
…8d7f87 (#3) * Added fixed log name support, take 2 See https://code.google.com/p/google-glog/issues/detail?id=209 and former google#19 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk. * Ifdef away fcntl on mingw * Use the defined HAVE_FCNTL instead * ifdef away tests as well add have_sys_wait for wait() on mingw. * OS_WINDOWS bug in fseeking to the end, only triggered here Co-authored-by: Ezequiel Lara Gomez <ezegomez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://code.google.com/p/google-glog/issues/detail?id=209 - this is an updated version of that patch.
It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk.