Added fixed log name support, take 2 (#489) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanhjli you can add Cherry-picked from 58d7f87 at the end of the commit message |
pkj415
approved these changes
Jan 20, 2022
…8d7f87 * Added fixed log name support, take 2 See https://code.google.com/p/google-glog/issues/detail?id=209 and former google#19 - this is an updated version of that patch. It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk. * Ifdef away fcntl on mingw * Use the defined HAVE_FCNTL instead * ifdef away tests as well add have_sys_wait for wait() on mingw. * OS_WINDOWS bug in fseeking to the end, only triggered here
nathanhjli
force-pushed
the
cherry_pick_timestamp_in_logfile_name
branch
from
43feee5
to
368833e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://code.google.com/p/google-glog/issues/detail?id=209 and former google#19 - this is an updated version of that patch.
It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk.
Ifdef away fcntl on mingw
Use the defined HAVE_FCNTL instead
ifdef away tests as well
add have_sys_wait for wait() on mingw.