Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify DLOG macro definition in NDEBUG mode #830

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

lstaroth
Copy link
Contributor

@lstaroth lstaroth commented Jun 6, 2022

Simplify the DLOG macro definition in NDEBUG mode with consistent logic

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #830 (82b2518) into master (b33e3ba) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   73.20%   73.17%   -0.04%     
==========================================
  Files          17       17              
  Lines        3281     3277       -4     
==========================================
- Hits         2402     2398       -4     
  Misses        879      879              
Impacted Files Coverage Δ
src/glog/logging.h.in 79.45% <ø> (-0.55%) ⬇️
src/stacktrace_unwind-inl.h 92.59% <0.00%> (-0.27%) ⬇️
src/vlog_is_on.cc 70.00% <0.00%> (-0.23%) ⬇️
src/logging.cc 74.67% <0.00%> (-0.02%) ⬇️
src/demangle.cc 97.48% <0.00%> (ø)
src/raw_logging.cc 100.00% <0.00%> (ø)
src/signalhandler.cc 6.45% <0.00%> (ø)
src/utilities.cc 67.88% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have some minor remarks. Could you also please rebase?

src/glog/logging.h.in Outdated Show resolved Hide resolved
src/glog/logging.h.in Outdated Show resolved Hide resolved
src/glog/logging.h.in Outdated Show resolved Hide resolved
src/glog/logging.h.in Outdated Show resolved Hide resolved
src/glog/logging.h.in Outdated Show resolved Hide resolved
src/glog/logging.h.in Outdated Show resolved Hide resolved
Co-authored-by: Sergiu Deitsch <sergiud@users.noreply.github.com>
@lstaroth
Copy link
Contributor Author

lstaroth commented Aug 6, 2022

@sergiud Thank you for your suggestions, I have edited

@sergiud sergiud added this to the 0.7 milestone Aug 6, 2022
@sergiud
Copy link
Collaborator

sergiud commented Aug 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants