-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for resource JSON marshalling #55
Comments
Hi @willnorris I would like to take this up. I will start with |
This can be labeled a good-first-issue since beginners can work on writing test for different resources at the same time. |
Hi @jamesgeorge007! Thank you for your interest in helping out. First, you will want to read our CONTRIBUTING.md guide. Second, you will want to get familiar with the code by reading through it and trying it out. Then, I suggest following the link to the original issue where it is explained what is needed in more detail. Thanks again, and I look forward to seeing PRs from you. |
@jamesgeorge007 hi 👋 just take a look at my commit referenced here and you will get the idea how to write the JSON test for different resources. Once it is clear just pick a resource that hasn't been covered by the tests and write a unit test for it 😄 |
@palash25 As mentioned above I'm not familiar with the code-base. It would be great if you could suggest on what test case is to be written specifically. |
I have mentioned how to get familiar with the codebase. It would be great if you could re-read my previous comment, and the referenced issues and the PRs. 😄 and then follow the steps accordingly |
@jamesgeorge007 Are you working on this issue? I would like to work on it 😅 |
@vaibhavsingh97 I think there are multiple resources that need the JSON marhsalling test so if you start with |
Note to @sagar23sj and all Hacktoberfest participants: Today is your last day to contribute to this repo for Hacktoberfest credit due to myself being OOO after today (through the end of the month). Thank you for your contributions, and we will hopefully see you throughout the year (and you won't wait until next October '23 😁 )! |
@JOAQUINPABLO001 - strike one before banning you from this repo. |
@gmlewis I would like to work on what's left of this issue if possible |
Thank you, @BahaBoualii ! Feel free to contribute. Please read the CONTRIBUTING.md guide and check out previously-merged PRs for this issue to see how we would like them to look. Thanks again, and we look forward to your contributions. |
see 5f1c20a for more details
The text was updated successfully, but these errors were encountered: