Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test for JSON marshalling of Commit - relates to (#55) #1333

Merged
merged 1 commit into from
Nov 19, 2019
Merged

added test for JSON marshalling of Commit - relates to (#55) #1333

merged 1 commit into from
Nov 19, 2019

Conversation

thomaslanghorst
Copy link
Contributor

This PR relates to (#55) and adds a test for the Commit resource.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Nov 17, 2019
gmlewis
gmlewis approved these changes Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @thomaslanghorst!
LGTM.
Merging.

@gmlewis gmlewis merged commit 2399959 into google:master Nov 19, 2019
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@thomaslanghorst @gmlewis
Add test for JSON marshaling of Commit (google#1333)
27ec0be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaslanghorst @gmlewis @googlebot