Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on JDK 17 as well as 11. #2198

Merged
merged 9 commits into from
Sep 23, 2022
Merged

Conversation

eamonnmcmanus
Copy link
Member

@eamonnmcmanus eamonnmcmanus commented Sep 23, 2022

Also fix some HTML javadoc warnings that JDK 17 chokes on. It really doesn't like you to write <h3> if the previous heading was <h1>.

@eamonnmcmanus eamonnmcmanus changed the title Build on JDK 8 and 17 as well as 11. Build on JDK 17 as well as 11. Sep 23, 2022
@eamonnmcmanus eamonnmcmanus changed the title Build on JDK 17 as well as 11. Build on JDK 8 and 17 as well as 11. Sep 23, 2022
@eamonnmcmanus eamonnmcmanus changed the title Build on JDK 8 and 17 as well as 11. Build on JDK 17 as well as 11. Sep 23, 2022
Apparently JDK 11 puts method javadoc inside `<h2>` while JDK 11 puts it
inside `<h3>`. Or something like that. Anyway it doesn't appear to be
possible to use `<h3>` _or_ `<h4>` and please both.
@eamonnmcmanus eamonnmcmanus merged commit 0864a02 into google:master Sep 23, 2022
@eamonnmcmanus eamonnmcmanus deleted the workflow branch September 23, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants