Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on JDK 17 as well as 11. #2198

Merged
merged 9 commits into from
Sep 23, 2022
Merged

Build on JDK 17 as well as 11. #2198

merged 9 commits into from
Sep 23, 2022

Commits on Sep 23, 2022

  1. Build on JDK 8 and 17 as well as 11.

    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    ba6c024 View commit details
    Browse the repository at this point in the history

  2. Remove JDK 8 for now. 

    `DefaultDateTypeAdapterTest` fails.
    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2e644a2 View commit details
    Browse the repository at this point in the history

  3. Restore JDK 8 and disable a test that fails there and on 17.

    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e3bf2e2 View commit details
    Browse the repository at this point in the history

  4. JDK 8 needs a bit more work, later.

    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e1fa361 View commit details
    Browse the repository at this point in the history

  5. Disable HTML validation in javadoc.

    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    4c97a05 View commit details
    Browse the repository at this point in the history

  6. Turn off -Xdoclint:-html for javac (not javadoc).

    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    7c295a0 View commit details
    Browse the repository at this point in the history

  7. Looks like we have to fix doclint for both javac and javadoc.

    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    a02a053 View commit details
    Browse the repository at this point in the history

  8. Gave up trying to disable javadoc warnings. Just went ahead and fixed… 

    … them.
    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    f89d9c4 View commit details
    Browse the repository at this point in the history

  9. More javadoc tweaks. 

    Apparently JDK 11 puts method javadoc inside `<h2>` while JDK 11 puts it
inside `<h3>`. Or something like that. Anyway it doesn't appear to be
possible to use `<h3>` _or_ `<h4>` and please both.
    @eamonnmcmanus
    eamonnmcmanus committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    3a3d1c4 View commit details
    Browse the repository at this point in the history