Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix soundness hole in Ref::into_ref and into_mut #721

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix soundness hole in Ref::into_ref and into_mut #721

merged 1 commit into from
Dec 13, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Dec 13, 2023

No description provided.

@joshlf joshlf changed the base branch from main to v0.7.x December 13, 2023 20:45
@joshlf joshlf mentioned this pull request Dec 13, 2023
Closed
11 tasks
@joshlf joshlf force-pushed the ref-unsoundness-fix-0.7 branch from 4563645 to 9040e22 Compare December 13, 2023 21:23
@joshlf joshlf marked this pull request as ready for review December 13, 2023 21:23
@joshlf joshlf requested a review from jswrenn December 13, 2023 21:23
@joshlf joshlf force-pushed the ref-unsoundness-fix-0.7 branch from 9040e22 to 34099d8 Compare December 13, 2023 21:37
jswrenn
jswrenn requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you perhaps add a compile_fail doc-test to ensure that this post-monomorphization error occurs?

@joshlf joshlf force-pushed the ref-unsoundness-fix-0.7 branch from 34099d8 to e19222b Compare December 13, 2023 23:00
@joshlf
Copy link
Member Author

joshlf commented Dec 13, 2023

Could you perhaps add a compile_fail doc-test to ensure that this post-monomorphization error occurs?

Done.

@joshlf joshlf requested a review from jswrenn December 13, 2023 23:01
@joshlf joshlf force-pushed the ref-unsoundness-fix-0.7 branch from e19222b to 25c299a Compare December 13, 2023 23:17
@joshlf joshlf force-pushed the ref-unsoundness-fix-0.7 branch from 25c299a to 783f449 Compare December 13, 2023 23:36
@joshlf
Fix soundness hole in Ref::into_ref and into_mut
3c1a56a 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.7.31.
@joshlf joshlf force-pushed the ref-unsoundness-fix-0.7 branch from 783f449 to 3c1a56a Compare December 13, 2023 23:45
@joshlf joshlf merged commit 7d3a8f9 into v0.7.x Dec 13, 2023
1 check passed
@joshlf joshlf deleted the ref-unsoundness-fix-0.7 branch December 13, 2023 23:46
joshlf added a commit that referenced this pull request Dec 13, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
535e8b1 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.6.6.
joshlf added a commit that referenced this pull request Dec 13, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
f2fae15 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.5.2.
joshlf added a commit that referenced this pull request Dec 13, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
02f7742 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.5.2.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
8e727be 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.4.1.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
5fa900b 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.3.2.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
41a460b 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.2.9.
@joshlf joshlf changed the title Ref unsoundness fix 0.7 Fix soundness hole in Ref::into_ref and into_mut Dec 14, 2023
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721) (#727)
653c2b3 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.2.9.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721) (#726)
50032ba 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.3.2.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721) (#723)
2d7a94f 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.6.6.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721) (#724)
2158b9d 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.5.2.
joshlf added a commit that referenced this pull request Dec 14, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721) (#725)
1f1885a 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.4.1.
joshlf added a commit that referenced this pull request Dec 28, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721)
25554f0 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.8.0-alpha.2.
github-merge-queue bot pushed a commit that referenced this pull request Dec 28, 2023
@joshlf
Fix soundness hole in Ref::into_ref and into_mut (#721) (#755)
dad47d5 
This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.8.0-alpha.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlf @jswrenn