Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix soundness hole in Ref::into_ref and into_mut #721

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix soundness hole in Ref::into_ref and into_mut #721

merged 1 commit into from
Dec 13, 2023
+201 −30

Commits on Dec 13, 2023

  1. Fix soundness hole in Ref::into_ref and into_mut 

    This commit implements the fix for #716 which will be released as a new
version in version trains 0.2, 0.3, 0.4, 0.5, 0.6, and 0.7. See #716 for
a description of the soundness hole and an explanation of why this fix
is chosen.

Unfortunately, due to dtolnay/trybuild#241, there is no way for us to
write a UI test that will detect a failure post-monomorphization, which
is when the code implemented in this change is designed to fail. I have
manually verified that unsound uses of these APIs now fail to compile.

Release 0.7.31.
    @joshlf
    joshlf committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3c1a56a View commit details
    Browse the repository at this point in the history