-
Notifications
You must be signed in to change notification settings - Fork 51
fix: use well-formatted URLs when setting breakpoints #535
Conversation
@kjin @googleapis/node-team this is just kinda hangin around :) Who should be reviewing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good.
is there a way to add a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this. Looks good once the tests are passing. I agree it would be nice if there was a way to test this.
@JustinBeckwith This PR needs work, I've been busy with other things so haven't had a chance to update it. @soldair @DominicKramer Currently, many tests will fail on Node master (or v10.x-staging) without this change... not sure if we need to explicitly test this. |
a52b5d1
to
0d35fad
Compare
@soldair @DominicKramer I'd appreciate a look on the newest commit. Thanks! |
b63e9cc
to
1e32a4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change LGTM. If the tests are good, go ahead and land this.
@ofrobots Ok will do. |
This will be able to land after PR #583 lands. |
Newer versions of Node will require that URLs be well-formatted when setting breakpoints (and will also return well-formatted URLs), as a result of nodejs/node#22223 (this will also affect versions of Node to which that PR will be backported). Enforcing well-formatted URLs will break the Debug Agent, so this PR addresses that.
If tests pass for current versions of Node, I think this should be merged now (rather than wait for Node 11).