This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
chore: make npm test platform independent
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
`cross-env` allows environment variables to be set in a consistent manner across diffent platforms.
3 tasks
DominicKramer
changed the title
npm test platform independentnpm test platform independent
|
PTAL |
| @@ -45,6 +45,7 @@ | |||
| "closure-npc": "*", | |||
| "codecov": "^3.0.4", | |||
| "coveralls": "^3.0.0", | |||
| "cross-env": "^5.2.0", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| "prepare": "npm run compile", | ||
| "presystem-test": "npm run compile", | ||
| "system-test": "mocha build/system-test", | ||
| "test": "./bin/run-test.sh", | ||
| "test-no-cover": "cross-env CLOUD_DEBUG_ASSERTIONS=1 mocha build/test --require source-map-support/register --timeout 4000 --R spec", | ||
| "test": "nyc npm run test-no-cover && nyc report", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JustinBeckwith
approved these changes
Nov 19, 2018
ofrobots
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.