fix: lower protobuf hash order of magnitude for PHP #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
vam-google
approved these changes
Dec 8, 2020
src/main/java/com/google/cloud/discotoproto3converter/proto3/DocumentToProtoConverter.java
Outdated
Show resolved
Hide resolved
|
@bshaffer Please add a TODO item to revert it to 2^29 with a link to the protobuf bug. |
This reverts commit a6c014d.
vam-google
added a commit
to vam-google/googleapis-discovery
that referenced
this pull request
May 3, 2021
…mber. This is a rollback of googleapis/disco-to-proto3-converter#16, which became possible after protobuf fixed the original issue protocolbuffers/protobuf#8114
vam-google
added a commit
to googleapis/googleapis-discovery
that referenced
this pull request
May 3, 2021
…mber. (#31) This is a rollback of googleapis/disco-to-proto3-converter#16, which became possible after protobuf fixed the original issue protocolbuffers/protobuf#8114
yoshi-automation
added a commit
to googleapis/python-compute
that referenced
this pull request
May 9, 2021
…mber. This is a rollback of googleapis/disco-to-proto3-converter#16, which became possible after protobuf fixed the original issue protocolbuffers/protobuf#8114 Source-Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Source-Date: Mon May 3 13:01:13 2021 -0700 Source-Repo: googleapis/googleapis-discovery Source-Sha: f9ff15d0795983956c1f94ec544176b257df31d1 Source-Link: googleapis/googleapis-discovery@f9ff15d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for protocolbuffers/protobuf#8114