Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 2^28 for protobuf hash #24

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Conversation

bshaffer
Copy link
Contributor

Once this PR is merge and tagged, we can merge this, which reverts #16

@bshaffer bshaffer requested a review from a team as a code owner January 27, 2021 16:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2021
Copy link
Collaborator

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests must be updated too

@vam-google vam-google merged commit 6f13b70 into googleapis:master Apr 30, 2021
@bshaffer bshaffer deleted the revert-16 branch April 30, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants