Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job for running queries #1072

Merged
merged 7 commits into from
Aug 24, 2015
Merged

Add job for running queries #1072

merged 7 commits into from
Aug 24, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 19, 2015

Uses #1068 as a base.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 19, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Aug 19, 2015

@dhermes Rebased after merge of #1068. PTAL.

@@ -153,3 +154,17 @@ def extract_table_to_storage(self, name, source, *destination_uris):
"""
return ExtractTableToStorageJob(name, source, destination_uris,
client=self)

def run_query(self, name, query):
"""Construct a job for running a BG SQL query.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

  1. System test forthcoming?
  2. Similarly, have you compared our BigQuery system tests to those in gcloud-node (I keep forgetting to bring this up, sorry if it's out of place here)
  3. This all seems very vanilla / identical to existing. Is it worth have something more generic we can use (included generated tests for getters, setters and deleters, or just a generic subclass of property that we can test once)?
  4. How close to "done" with BigQuery? (Cut release at that point?)

@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

Thanks for the tweaks. As for my other questions?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 20, 2015

System test forthcoming?

Yes, shortly.

Similarly, have you compared our BigQuery system tests to those in gcloud-node (I keep forgetting to bring this up, sorry if it's out of place here).

I've looked at them: we have similar coverage, except one missing for #1068.

This all seems very vanilla / identical to existing. Is it worth have something more generic we can use (included generated tests for getters, setters and deleters, or just a generic subclass of property that we can test once)?

We could bag the property/validation stuff, and just rely on docs for the user-settable configuration attributes. Or we could write a 'validating descriptor' helper and use that instead of custom property methods.

How close to "done" with BigQuery? (Cut release at that point?)

We don't have coverage for the /upload APIs (multipart/resumable, just like storage). And we're missing Client.list_jobs. Other than that, I think we're close.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 20, 2015

Rebased on top of #1075.

@dhermes
Copy link
Contributor

dhermes commented Aug 21, 2015

Ping me when #1075 is in.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 23, 2015

@dhermes rebased after merge of #1075.

@dhermes
Copy link
Contributor

dhermes commented Aug 24, 2015

LGTM

tseaver added a commit that referenced this pull request Aug 24, 2015
@tseaver tseaver merged commit ddb26e2 into googleapis:master Aug 24, 2015
@tseaver tseaver deleted the bigquery-jobs_query branch August 24, 2015 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants