Replace validating property boilerplate w/ custom descriptors. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Addresses point #3 of: #1072 (comment)
|
@dhermes PTAL: I think you'll like the linecount reduction. |
| return self | ||
| return getattr(instance._configuration, self._backing_name) | ||
|
|
||
| def _validate(self, value): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
General comment: this is awesome. Let's also file a bug to do this for other discovery-based APIs and then put these classes in core? |
|
|
||
| :raises: ValueError for invalid value types. | ||
| """ | ||
| if not isinstance(value, bool): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. Do or don't update the error message for multiple types (e.g. |
tseaver
added a commit
that referenced
this pull request
Aug 23, 2015
Replace validating property boilerplate w/ custom descriptors.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…oogleCloudPlatform/python-docs-samples#1075) In particular, this change: - changes to use a consistent "_id" suffix for resource name components - uses "data" instead of "text", since encryption is not restricted to text - substitutes "ciphertext" for "encrypted {text, data}" - spells "crypto key" and "key ring" each as two separate words, as in the API Tracking bug: http://b/64758639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses point
#3of:#1072 (comment)