-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing HappyBase Table atomic counter helpers. #1514
Conversation
""" | ||
row = self._low_level_table.row(row) | ||
if isinstance(column, six.binary_type): | ||
column = column.decode('utf-8') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@jgeewax HappyBase also has a
|
This LGTM, although from a readability nit standpoint |
RE: "Hard to follow." That's the kind of feedback I was hoping to surface (by breaking into small PRs). Do you think the low-level row should handle more of the responsibilities? Do you think the method should use a helper? etc. |
Perhaps just some comments in-line. Poor example, but what is |
(this also just may be my unfamiliarity with bigtable showing) |
column_cells = modified_cells[column_family_id][column_qualifier] | ||
if len(column_cells) != 1: | ||
raise ValueError('Expected server to return one modified cell.') | ||
bytes_value = column_cells[0][0] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I don't think it's your unfamiliarity, but that also is good in that you don't have a bias towards how things should be. I had to look up what |
Wow, that is a lot to explain. |
Luckily the docstring proves that a picture is worth a thousand words: {
u'col-fam-id': {
b'col-name1': [
(b'cell-val', datetime.datetime(...)),
(b'cell-val-newer', datetime.datetime(...)),
],
b'col-name2': [
(b'altcol-cell-val', datetime.datetime(...)),
],
},
u'col-fam-id2': {
b'col-name3-but-other-fam': [
(b'foo', datetime.datetime(...)),
],
},
} |
Ah, very helpful. Can you include a comment that notes the expected format of the |
62b8e75
to
1285aa3
Compare
@jonparrott PTAL |
LGTM, please squash commits. |
1285aa3
to
bb49935
Compare
Implementing HappyBase Table atomic counter helpers.
No description provided.