Adding HappyBase connection pool. #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Unsure of the usage of this - but is there any reason why you didn't implement HappyBase's Pool methods |
|
@jonparrott The "final" implementation is elsewhere. I am just breaking it into small chunks to make review go smoothly / make it easier to iterate on changes. That version also has full-fledged docs. |
|
I see. That's fine. This LGTM. |
dhermes
added a commit
that referenced
this pull request
Feb 23, 2016
Adding HappyBase connection pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @jgeewax this is the last
bigtablemodule that needs to be added. (This isn't the last PR, the modules are being built up piece by piece, but getting closer and closer.)For comparison: https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/pool.py