Splitting Bigtable Row into 3 classes based on the mutation type / RPC method used in commit() #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
|
||
| :rtype: :class:`.Row` | ||
| :rtype: :class:`.DirectRow` |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver just saw tests were failing on Travis. Looking into it. What do we need to do to keep this review moving? Really close to the finish line and want to get a release out |
|
OK the failure is simple to address (just a long failure) |
|
*lint failure. Phone autocorrect! |
For now, just renaming Row->DirectRow and creating 2 do-nothing subclasses. Class will be torn down in subsequent commits.
Simplifying most downstream issues by just removing any code in DirectRow that branched based on the presence of filter_.
Also simplifying DirectRow.commit() in the process.
Factoring behavior out into a non-public helper _set_cell() and using that helper in both DirectRow and ConditionalRow.
Factoring behavior out into a non-public helper _delete() and using that helper in both DirectRow and ConditionalRow. Also making sure ConditionalRow.delete() gets tested (codepath was only previously traversed via the parent class).
Factoring behavior out into a non-public helper _delete_cells() and using that helper in both DirectRow and ConditionalRow. Also making sure ConditionalRow.delete_cell(s) get tested (codepaths were only previously traversed via the parent class).
Long-term fix will be to create the `gcloud.bigtable.row_filters` module to reduce the amount of code in `gcloud.bigtable.row`. Also removing superflous assignment.
|
This mostly LGTM, pending the one open item. |
|
LGTM |
|
Merging this, will handle the open item in a small separate PR. |
dhermes
added a commit
that referenced
this pull request
Mar 8, 2016
Splitting Bigtable Row into 3 classes based on the mutation type / RPC method used in commit()
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 10, 2016
This is a follow-up to googleapis#1557 and prevents strange-ly true statements like `isinstance(cond_row, DirectRow)`.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 10, 2016
This is a follow-up to googleapis#1557 and prevents strange-ly true statements like `isinstance(cond_row, DirectRow)`.
This was referenced Mar 10, 2016
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 11, 2016
This is a follow-up to googleapis#1557 and prevents strange-ly true statements like `isinstance(cond_row, DirectRow)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs are still being updated, but I wanted to get this out there to speed up the review. Alternate implementation based on #1550.
I strongly urge reviewers to examine this commit-by-commit. The commit messages are fairly helpful (for the most part) and the diff of the PR as a whole is not so easy on the eyes.
Fixes #1548.
/cc @jonparrott @jgeewax