Making common subclass for Bigtable DirectRow and ConditionalRow. #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -63,5 +63,6 @@ level. For example: | |||
| :members: | |||
| :undoc-members: | |||
| :show-inheritance: | |||
| :inherited-members: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
This is a follow-up to googleapis#1557 and prevents strange-ly true statements like `isinstance(cond_row, DirectRow)`.
dhermes
force-pushed
the
pr-1557-followup
branch
from
d5565f1 to
628c803
Compare
dhermes
added a commit
that referenced
this pull request
Mar 11, 2016
Making common subclass for Bigtable DirectRow and ConditionalRow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1557 and prevents strange-ly true statements like
isinstance(cond_row, DirectRow).Sorry it took me so many days. Code has been completely written for 2+ days but I haven't ever had my laptop near internet long enough to push it.