Re-enabling redefined-builtin for Pylint. #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Merged
| @@ -147,7 +147,7 @@ class InternalServerError(ServerError): | |||
| code = 500 | |||
|
|
|||
|
|
|||
| class NotImplemented(ServerError): | |||
| class NotImplementedMethod(ServerError): | |||
| """Exception mapping a '501 Not Implemented' response.""" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
re-enable-builtins-lint-check
branch
from
484a5ce to
1792d20
Compare
|
@tseaver PTAL |
|
LGTM |
|
Will squash then merge. |
In the process, refactoring places where builtins were used intentionally or un-intentionally.
dhermes
force-pushed
the
re-enable-builtins-lint-check
branch
from
1792d20 to
aefdd22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process, refactoring places where builtins were used intentionally or un-intentionally.
Inspired by discussion with @rimey in #1691.