Factor out datastore API surface. #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
The API helper indirection SGTM. One question: should the tests for the |
|
Does #2099 make it clear how the gRPC test swapping is done? LGTY? |
|
Hmmm, it looks as though we don't have explicit tests for the |
|
It's unclear to me. Can we handle outside this PR? (Working on fixing the merge conflict right now.) |
This is in preparation for a gRPC equivalent of that API.
dhermes
force-pushed
the
datastore-prep-for-grpc
branch
from
fd7e7c0
to
42a3353
Compare
|
#2113 tracks the indirect coverage issue. LGTM pending Travis. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for a gRPC equivalent of that API.