-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gRPC for datastore API. #2099
Conversation
@tseaver I don't have a flag for disabling it, but am happy to add it, just wanted to here from you about it. |
from gcloud.datastore._generated.datastore_pb2 import RollbackResponse | ||
from gcloud.datastore._generated.datastore_pb2 import RunQueryRequest | ||
from gcloud.datastore._generated.datastore_pb2 import RunQueryResponse | ||
# END: Manually added imports |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The environment flags for pubsub and logging were basically there to allow me to test with the gRPC team, without turning the feature on by default. We can probably leave them out here, if you don't feel paranoid about the gRPC stuff breaking us. |
I don't feel paranoid |
Hmm. |
Hmm aside, let's get #2097 settled and then move back here. (I'll resolve the merge conflict.) |
329b063
to
a820311
Compare
@tseaver Rebased after #2097, PTAL. The question remaining is how to update As for worry about gRPC, I was more saying I'm not worried about people having imports work but wanting to turn it off. And those people can just hack and edit the module-private |
This is the canonical case for |
Trying to avoid the |
a820311
to
cd9bc26
Compare
@tseaver Check out the latest commit |
from grpc.beta import implementations as beta_implementations | ||
from grpc.beta import interfaces as beta_interfaces | ||
from grpc.framework.common import cardinality | ||
from grpc.framework.interfaces.face import utilities as face_utilities | ||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM |
NOTE: Has #2097 as diffbase.