WIP: Refactor conformance tests for firestore. #6291

tseaver · 2018-10-23T19:23:08Z

Use 'pytest.mark.parametrize' to create a testcase per textproto file.

Note that a bunch of them fail. :(

googlebot · 2018-10-23T23:00:20Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Note that this will conflict with #6291, but the master is red.

See #6290. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Note that a *bunch* of them fail. :(

…rs including dots

… param to set

…sts still fail; I don't even know what these things are yet

…hers :)

Normalize method order and match it in the testcase class.

Simplify / clarify implementation.

Also for '_helpers._parse_field_name'. Fix bug uncovered thereby in '_parse_field_name'.

Put it next to the only function which raises it.

Move tests to match location in file of the FUT.

Rename 'pbs_for_set' -> 'pbs_for_set_no_merge'.

Simplify: because no merge, the write message w/ update is *always* sent, even if empty before or after pulling out transforms.

Pass it as a keyword argument everywhere. Add explicit tests for the 'split_on_dots=False' cases.

…hs'.

tseaver · 2018-11-15T03:29:26Z

@crwilcox Please flip the CLA flag to allow me to merge this PR.

googlebot · 2018-11-15T05:29:13Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Closes googleapis#6290. Breaking change from `firestore-0.30.0`: revert to merge not being an option; instead make it a bool or a list param to `set`. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Blacklist conformance tests for transforms we don't yet have (ArrayDelete, ArrayUnion, and Delete) Re-import google-cloud-common testdata textprotos: discard older, renamed versions.

tseaver added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: firestore Issues related to the Firestore API. labels Oct 23, 2018

tseaver assigned mcdonc Oct 23, 2018

tseaver requested a review from crwilcox as a code owner October 23, 2018 19:23

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2018

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 23, 2018

mcdonc mentioned this pull request Oct 25, 2018

Firestore: implement set such that it passes conformance testing #6307

Closed

This was referenced Oct 25, 2018

Bigtable: create snippets.py for python docs. #6012

Merged

Firestore: fix error from new flake8 version. #6320

Merged

tseaver added a commit that referenced this pull request Oct 26, 2018

Firestore: fix error from new flake8 version. (#6320)

7e26ab2

Note that this will conflict with #6291, but the master is red.

tseaver force-pushed the 6290-firestore-refactor_conformance_tests branch 2 times, most recently from f975741 to ab29550 Compare November 12, 2018 18:40

tseaver force-pushed the 6290-firestore-refactor_conformance_tests branch from f1dee59 to 1fe9959 Compare November 13, 2018 23:02

crwilcox approved these changes Nov 14, 2018

View reviewed changes

tseaver and others added 13 commits November 14, 2018 18:04

WIP: Refactor conformance tests for firestore.

d0e7745

See #6290. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Note that a *bunch* of them fail. :(

unused imports

0ee56fe

fix conformance tests which assert that keys can contain nonalpha cha…

d05e97a

…rs including dots

WIP: set conformance not achieved

50b58b6

Lint.

5587407

checkpoint checkin

2a3bbd2

work towards making set tests pass

1882795

revert to merge not being an option; instead make it a bool or a list…

f32fb45

… param to set

WIP: set conformance tests

29c8dc5

WIP: checkpoint... ArrayDelete, ArrayUnion, and Delete related set te…

3f27b8f

…sts still fail; I don't even know what these things are yet

blacklist conformance tests for transforms we don't yet have

4fcdaf6

WIP: traunch of set tests; 3 still fail which, when fixed, break 3 ot…

c50fc9c

…hers :)

blacklist all tests that use features we dont have

3fe44ce

tseaver added 17 commits November 14, 2018 18:04

Lint

f4f0529

Ajust sys tests: don't passing explicit 'exists' to update.

fc6fcba

Explicit coverage for '_helpers.FieldPath'.

cccdfe4

Normalize method order and match it in the testcase class.

Explicit coverage for '_helpers.extract_field_paths'.

9d3df11

Simplify / clarify implementation.

Add explicit coverage for '_helpers.parse_field_path'.

8f8a0b0

Also for '_helpers._parse_field_name'. Fix bug uncovered thereby in '_parse_field_name'.

Move '_helpers.ReadAfterWriteError' exception

2f569d4

Put it next to the only function which raises it.

Expand tests for '_helpers.filter_document_data_by_field_paths'.

93cbb23

Move tests to match location in file of the FUT.

Explicit coverage for '_helpers.get_field_path'.

417bbc2

Split out 'pbs_for_set_with_merge' from 'pbs_for_set'.

08bba84

Rename 'pbs_for_set' -> 'pbs_for_set_no_merge'.

Explicit coverage for '_helpers.pbs_for_set_no_merge'.

9677e79

Simplify: because no merge, the write message w/ update is *always* sent, even if empty before or after pulling out transforms.

Make 'split_on_dots' arg to 'process_server_timestamp' explicit.

d661a1d

Pass it as a keyword argument everywhere. Add explicit tests for the 'split_on_dots=False' cases.

Factor out the simpler 'merge=True' case into '_helpers.all_merge_pat…

70185fa

…hs'.

100% coverage in testcase module.

845c02a

Incremental coverage for '_helpers.pbs_for_set_with_merge'.

69d5366

Typo.

09d3f89

Coverage for '_helpers.normalize_merge_paths'.

05bb4df

Explicit coverage for '_helpers.pb_for_set_with_merge'.

581e006

tseaver force-pushed the 6290-firestore-refactor_conformance_tests branch from 1fe9959 to 581e006 Compare November 15, 2018 00:59

tseaver added 3 commits November 14, 2018 20:14

Fix overlong lines introduced in PR #6481.

1d0418f

Coverage for 'DocumentReference.update'.

a477308

Lint

52031e7

crwilcox added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 15, 2018

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2018

tseaver merged commit f22abbe into master Nov 15, 2018

tseaver deleted the 6290-firestore-refactor_conformance_tests branch November 15, 2018 17:49

tseaver mentioned this pull request Nov 16, 2018

[Firestore] Field Path escaping in python doesn't match other languages #6549

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Refactor conformance tests for firestore. #6291

WIP: Refactor conformance tests for firestore. #6291

tseaver commented Oct 23, 2018

googlebot commented Oct 23, 2018

tseaver commented Nov 15, 2018

googlebot commented Nov 15, 2018

WIP: Refactor conformance tests for firestore. #6291

WIP: Refactor conformance tests for firestore. #6291

Conversation

tseaver commented Oct 23, 2018

googlebot commented Oct 23, 2018

tseaver commented Nov 15, 2018

googlebot commented Nov 15, 2018