-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor conformance tests for firestore. #6291
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Note that this will conflict with #6291, but the master is red.
f975741
to
ab29550
Compare
f1dee59
to
1fe9959
Compare
See #6290. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Note that a *bunch* of them fail. :(
…rs including dots
…sts still fail; I don't even know what these things are yet
Normalize method order and match it in the testcase class.
Simplify / clarify implementation.
Also for '_helpers._parse_field_name'. Fix bug uncovered thereby in '_parse_field_name'.
Put it next to the only function which raises it.
Move tests to match location in file of the FUT.
Rename 'pbs_for_set' -> 'pbs_for_set_no_merge'.
Simplify: because no merge, the write message w/ update is *always* sent, even if empty before or after pulling out transforms.
Pass it as a keyword argument everywhere. Add explicit tests for the 'split_on_dots=False' cases.
1fe9959
to
581e006
Compare
@crwilcox Please flip the CLA flag to allow me to merge this PR. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Closes googleapis#6290. Breaking change from `firestore-0.30.0`: revert to merge not being an option; instead make it a bool or a list param to `set`. Use 'pytest.mark.parametrize' to create a testcase per textproto file. Blacklist conformance tests for transforms we don't yet have (ArrayDelete, ArrayUnion, and Delete) Re-import google-cloud-common testdata textprotos: discard older, renamed versions.
See #6290.
Use 'pytest.mark.parametrize' to create a testcase per textproto file.
Note that a bunch of them fail. :(