Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(monitoring): rewrite logic for skipping VPCSC runs #9389

Closed
wants to merge 4 commits into from
Closed

tests(monitoring): rewrite logic for skipping VPCSC runs #9389

wants to merge 4 commits into from

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 2, 2019 •
edited
Loading

  • Rely on GOOGLE_CLOUD_TESTS_IN_VPCSC for running/skipping VPCSC tests
  • Re-write tests to skip fewer runs?

CC @bmccutchon

@busunkim96 busunkim96 added testing api: monitoring Issues related to the Cloud Monitoring API. labels Oct 2, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2019
tseaver
tseaver reviewed Oct 3, 2019
View reviewed changes
monitoring/tests/system/test_vpcsc.py
# If IS_INSIDE_VPCSC is set, these environment variables should also be set
if IS_INSIDE_VPCSC:
PROJECT_INSIDE = os.environ["PROJECT_ID"]
PROJECT_OUTSIDE = os.environ["GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Much better to have the single flag.

@busunkim96 busunkim96 requested a review from crwilcox October 3, 2019 21:25
@tseaver tseaver changed the title tests: rewrite logic for skipping VPCSC runs tests(monitoring): rewrite logic for skipping VPCSC runs Oct 4, 2019
@busunkim96 busunkim96 marked this pull request as ready for review October 8, 2019 23:38
@busunkim96 busunkim96 mentioned this pull request Oct 9, 2019
Merged
@tseaver
Copy link
Contributor

tseaver commented Oct 29, 2019

Seems to conflict with PR #9437 (already merged) and #9564 (pending).

@busunkim96
Copy link
Contributor Author

Closing for now, will revisit once the pending PR is merged

@busunkim96 busunkim96 closed this Oct 29, 2019
@busunkim96 busunkim96 deleted the monitoring-vpcsc branch October 29, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tseaver @googlebot