Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitoring): make VPCSC env comparison case-insensitive #9564

Merged
merged 5 commits into from
Nov 6, 2019

Conversation

steinwaywhw
Copy link
Contributor

The actual environment variable value may be True, instead of true. So just make it case insensitive.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
@tseaver tseaver changed the title Make VPCSC env comparison case-insensitive. fix(monitoring): make VPCSC env comparison case-insensitive Oct 29, 2019
monitoring/noxfile.py Outdated Show resolved Hide resolved
monitoring/noxfile.py Outdated Show resolved Hide resolved
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 31, 2019
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@steinwaywhw
Copy link
Contributor Author

@googlebot I fixed it.

@steinwaywhw
Copy link
Contributor Author

steinwaywhw commented Nov 4, 2019

Hi @tseaver, please sign CLA using your personal email. See link above, or equivalently this one

@tseaver
Copy link
Contributor

tseaver commented Nov 5, 2019

@googlebot I consent.

@tseaver
Copy link
Contributor

tseaver commented Nov 5, 2019

@steinwaywhw I made those edits through the web: the e-mail associated with them (tseaver@palladion.com) is my normal one.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 6, 2019
Copy link
Contributor Author

@steinwaywhw steinwaywhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark suggested edits as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants