Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Commit

Permalink
fix: drop support for node.js 4.x and 9.x (#97)
Browse files Browse the repository at this point in the history
  • Loading branch information
JustinBeckwith authored Jun 12, 2018
1 parent 53d3699 commit 233c58e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 27 deletions.
34 changes: 8 additions & 26 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,24 @@ workflows:
version: 2
tests:
jobs: &workflow_jobs
- node4:
- node6:
filters: &all_commits
tags:
only: /.*/
- node6:
filters: *all_commits
- node8:
filters: *all_commits
- node9:
filters: *all_commits
- node10:
filters: *all_commits
- lint:
requires:
- node4
- node6
- node8
- node9
- node10
filters: *all_commits
- docs:
requires:
- node4
- node6
- node8
- node9
- node10
filters: *all_commits
- system_tests:
Expand Down Expand Up @@ -62,9 +54,9 @@ workflows:
only: master
jobs: *workflow_jobs
jobs:
node4:
node6:
docker:
- image: 'node:4'
- image: 'node:6'
user: node
steps: &unit_tests_steps
- checkout
Expand Down Expand Up @@ -95,29 +87,19 @@ jobs:
name: Submit coverage data to codecov.
command: node_modules/.bin/codecov
when: always
node6:
docker:
- image: 'node:6'
user: node
steps: *unit_tests_steps
node8:
docker:
- image: 'node:8'
user: node
steps: *unit_tests_steps
node9:
docker:
- image: 'node:9'
user: node
steps: *unit_tests_steps
node10:
docker:
- image: 'node:10'
user: node
steps: *unit_tests_steps
lint:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand All @@ -139,7 +121,7 @@ jobs:
NPM_CONFIG_PREFIX: /home/node/.npm-global
docs:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand All @@ -150,7 +132,7 @@ jobs:
command: npm run docs
sample_tests:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand All @@ -177,7 +159,7 @@ jobs:
working_directory: /home/node/compute-samples
system_tests:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand All @@ -200,7 +182,7 @@ jobs:
when: always
publish_npm:
docker:
- image: 'node:8'
- image: 'node:10'
user: node
steps:
- checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=4.0.0"
"node": ">=6.0.0"
},
"repository": "googleapis/nodejs-compute",
"main": "./src/index.js",
Expand Down

0 comments on commit 233c58e

Please sign in to comment.