This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: drop support for node.js 4.x and 9.x #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 1581 1581
=====================================
Hits 1581 1581Continue to review full report at Codecov.
|
fhinkel
approved these changes
Jun 12, 2018
|
Very much in favor of this. Do we need to change the version of the library or do something else special? |
|
Nope! We are working on multiple breaking changes right now (see #99). After they're all in, we will bump the version in it's own PR and ship a new release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removes Node.js 4.x and 9.x from the CI. Resolves #64.