Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: require use of new #99

Merged
merged 2 commits into from
Jun 12, 2018
Merged

fix: require use of new #99

merged 2 commits into from
Jun 12, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jun 12, 2018

BREAKING CHANGE: This eliminates the ability to use the API without instantiating a new Compute object. Resolves #63.

@JustinBeckwith JustinBeckwith requested review from stephenplusplus and a team June 12, 2018 04:45
@ghost ghost assigned JustinBeckwith Jun 12, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2018
@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #99   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines        1583   1581    -2     
=====================================
- Hits         1583   1581    -2
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9795b27...d35e173. Read the comment docs.

Copy link

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine. Let's make sure we get all the other semver major changes in before this gets released.

.gitignore Outdated
google-cloud-logging-bunyan-*.tgz

This comment was marked as spam.

This comment was marked as spam.

@JustinBeckwith JustinBeckwith merged commit 53d3699 into googleapis:master Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants