Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default proto package name is the module name, not "" #176

Closed
wants to merge 4 commits into from
Closed

fix: default proto package name is the module name, not "" #176

wants to merge 4 commits into from

Conversation

0x2b3bfa0
Copy link
Contributor

Closes #175; please refer to #171 for context.

@0x2b3bfa0 0x2b3bfa0 requested a review from a team as a code owner January 8, 2021 00:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #176 (3e61431) into master (6a43682) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          862       895   +33     
  Branches       149       163   +14     
=========================================
+ Hits           862       895   +33     
Impacted Files Coverage Δ
proto/modules.py 100.00% <ø> (ø)
proto/_package_info.py 100.00% <100.00%> (ø)
proto/enums.py 100.00% <100.00%> (ø)
proto/marshal/collections/repeated.py 100.00% <100.00%> (ø)
proto/marshal/marshal.py 100.00% <100.00%> (ø)
proto/message.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360d247...3e61431. Read the comment docs.

@parthea
Copy link
Contributor

parthea commented Apr 29, 2022

I've opened #309 as the branch in this PR is no longer active.

@parthea parthea closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: default proto package name is the module name, not ""
3 participants