Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default proto package name is the module name, not "" #309

Merged
merged 5 commits into from
May 2, 2022
Merged

fix: default proto package name is the module name, not "" #309

merged 5 commits into from
May 2, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 19, 2022 •
edited
Loading

Fixes #175

This is similar to #176 but the PR is stale and the branch is no longer active

@parthea parthea requested review from a team as code owners April 19, 2022 09:09
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@079fc6a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e8b5205 differs from pull request most recent head 5066747. Consider uploading reports for the commit 5066747 to get more accurate results

@@           Coverage Diff            @@
##             main      #309   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        22           
  Lines           ?      1003           
  Branches        ?       226           
========================================
  Hits            ?      1003           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079fc6a...5066747. Read the comment docs.

This was referenced Apr 29, 2022
Closed
Closed
@parthea parthea self-assigned this Apr 29, 2022
@parthea parthea removed their assignment Apr 29, 2022
@parthea parthea requested a review from atulep April 29, 2022 22:40
vam-google
vam-google approved these changes Apr 30, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea merged commit 3148a1c into main May 2, 2022
@parthea parthea deleted the parthea-patch-1 branch May 2, 2022 10:00
@release-please release-please bot mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

@atulep atulep Awaiting requested review from atulep

Assignees

@atulep atulep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: default proto package name is the module name, not ""
3 participants
@parthea @vam-google @atulep