Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regenerate pb2 files for compatibility with protobuf 5.x #234

Merged
merged 19 commits into from
Jun 19, 2024
Merged

fix: regenerate pb2 files for compatibility with protobuf 5.x #234

merged 19 commits into from
Jun 19, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 6, 2024 •
edited
Loading

Fixes #232

BEGIN_COMMIT_OVERRIDE
fix: regenerate pb2 files for compatibility with protobuf 5.x
fix(deps): require protobuf>=3.20.2
END_COMMIT_OVERRIDE

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2024
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 6, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Jun 6, 2024
@parthea
Copy link
Contributor Author

parthea commented Jun 11, 2024 •
edited
Loading

Wait for googleapis/python-grpc-google-iam-v1#97

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea parthea marked this pull request as ready for review June 11, 2024 15:06
@parthea parthea requested a review from a team as a code owner June 11, 2024 15:07
@parthea parthea assigned ohmayr and unassigned dizcology Jun 11, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea parthea added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 11, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 11, 2024
@parthea parthea mentioned this pull request Jun 11, 2024
Merged
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea
Copy link
Contributor Author

parthea commented Jun 19, 2024

@ohmayr PTAL

@parthea parthea merged commit c77c0dc into main Jun 19, 2024
13 checks passed
@parthea parthea deleted the regenerate-pb2 branch June 19, 2024 15:22
@release-please release-please bot mentioned this pull request Jun 19, 2024
Merged
@parthea parthea added the release-please:force-run To run release-please label Jun 19, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@ohmayr ohmayr

Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while using the python backend via setting the PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python env var
4 participants
@parthea @ohmayr @dizcology @yoshi-kokoro