Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regenerate pb2 files for compatibility with protobuf 5.x #97

Merged
merged 14 commits into from
Jun 20, 2024
Merged

fix: regenerate pb2 files for compatibility with protobuf 5.x #97

merged 14 commits into from
Jun 20, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 6, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix: regenerate pb2 files for compatibility with protobuf 5.x
fix(deps): Require protobuf>=3.20.2, protobuf<6
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: iam Issues related to the googleapis/python-grpc-google-iam-v1 API. labels Jun 6, 2024
@parthea parthea force-pushed the add-support-for-protobuf-5 branch from 51713fa to b47d532 Compare June 6, 2024 19:32
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea parthea mentioned this pull request Jun 11, 2024
Merged
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 11, 2024
@parthea parthea closed this Jun 11, 2024
@parthea parthea reopened this Jun 11, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@parthea
Copy link
Contributor Author

parthea commented Jun 11, 2024 •
edited
Loading

Wait for googleapis/python-api-common-protos#234

@parthea parthea self-assigned this Jun 19, 2024
@parthea parthea marked this pull request as ready for review June 20, 2024 20:12
@parthea parthea requested a review from a team as a code owner June 20, 2024 20:12
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2024
@parthea parthea assigned ohmayr and unassigned parthea Jun 20, 2024
@parthea
Copy link
Contributor Author

parthea commented Jun 20, 2024

@ohmayr PTAL

@parthea parthea merged commit ac15e1c into main Jun 20, 2024
17 checks passed
@parthea parthea deleted the add-support-for-protobuf-5 branch June 20, 2024 21:54
@release-please release-please bot mentioned this pull request Jun 20, 2024
Merged
@parthea parthea added the release-please:force-run To run release-please label Jun 20, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Jun 20, 2024
@parthea parthea mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@ohmayr ohmayr

Labels
api: iam Issues related to the googleapis/python-grpc-google-iam-v1 API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @ohmayr