Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate IAM factory helpers #100

Closed
tseaver opened this issue Nov 19, 2020 · 0 comments · Fixed by #101
Closed

Undeprecate IAM factory helpers #100

tseaver opened this issue Nov 19, 2020 · 0 comments · Fixed by #101
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 19, 2020

In addition to deprecating legacy role assignments, fd47fda (googleapis/google-cloud-python#9869) deprecated the Policy.user, Policy.service_account, Policy.group, Policy.domain, Policy.all_users, and Policy.authenticated_users entity factory helpers.

ISTM that those helpers should not be deprecated: they hide spelling details from users, and were not part of the "binding assigments" bit being deprecated (the assignable Policy.owners, Policy.editors, Policy.viewers properties): one still has to be able to construct the correctly-spelled entity when using the expected Policy.bindings[<ROLENAME>] spelling.
tseaver added a commit that referenced this issue Nov 19, 2020
@tseaver
fix: undprecate entity factory helpers
c35f2c5 
Closes #100
@tseaver tseaver mentioned this issue Nov 19, 2020
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 20, 2020
@busunkim96 busunkim96 added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Nov 20, 2020
tseaver added a commit that referenced this issue Jun 30, 2021
@tseaver
fix: undprecate entity factory helpers (#101)
1fbee03 
Closes #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: undeprecate entity factory helpers googleapis/python-api-core
3 participants
@tseaver @busunkim96 @yoshi-automation