Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Warn that default dialect is changing to "standard" #196

Merged
merged 6 commits into from
Aug 15, 2018

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Aug 15, 2018

Towards issue #195

CC @RafaelAMello

@tswast tswast requested a review from max-sixty August 15, 2018 17:36
@tswast
Copy link
Collaborator Author

tswast commented Aug 15, 2018

@max-sixty
Copy link
Contributor

Thanks a lot for doing all that - sorry you had to go through all the updates. Looks great from here

@tswast tswast merged commit d6b7507 into googleapis:master Aug 15, 2018
@tswast tswast deleted the issue-195-standard-sql branch August 15, 2018 19:13
@max-sixty
Copy link
Contributor

I been using https://github.com/ambv/black on some small projects, which helps with the formatting for these sorts of broad changes (much easier than autopep8)

It's a big initial diff for existing projects, though

@tswast
Copy link
Collaborator Author

tswast commented Aug 15, 2018

black looks interesting. pandas-gbq has some inconsistent formatting, so applying black might be a good idea anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants