[ENH] cache credentials in-memory #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Aug 31, 2018
tswast
force-pushed
the
issue-198-cache-credentials
branch
from
874bac8 to
9ceb8f7
Compare
stickler-ci
reviewed
Aug 31, 2018
max-sixty
reviewed
Aug 31, 2018
| self._credentials = None | ||
| self._project = None | ||
|
|
||
| @property |
There was a problem hiding this comment.
Do we need the getters and setters? Are they doing anything beyond attributes? It's not bloating the interface, so I don't have a strong view.
There was a problem hiding this comment.
My thought is that these can be used to provide documentation about the settable properties.
|
This is going to radically reduce the latency, thanks! |
tswast
force-pushed
the
issue-198-cache-credentials
branch
from
9ceb8f7 to
cdfc1aa
Compare
stickler-ci
reviewed
Sep 1, 2018
This commit adds a global pandas_gbq.context variable which caches the project ID and credentials across calls to read_gbq and to_gbq.
tswast
force-pushed
the
issue-198-cache-credentials
branch
from
cdfc1aa to
9863ac1
Compare
tswast
added
the
do not merge
|
Looks good! |
tswast
removed
the
do not merge
|
Shall we merge? I'll start testing internally as soon as we do |
|
We can merge now. I want to clean up the docs a little more before we release. |
This was referenced Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a global Context object to cache credentials in.
This PR is a work in progress towards #198 and somewhat towards #103.
Do not merge.
I still need to flesh out the unit tests for this behavior.It is a new feature, so we should probably release 0.6.1 with the recent bug fixes first.