Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloads do not populate properties from all headers #490

Closed
tseaver opened this issue Jul 6, 2021 · 0 comments · Fixed by #488
Closed

Downloads do not populate properties from all headers #490

tseaver opened this issue Jul 6, 2021 · 0 comments · Fixed by #488
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Jul 6, 2021

See #451 (comment)

The following headers should be used to populate the corresponding properties:

HTTP Header Property
ETag etag
x-goog-generation generation
x-goog-metageneration metageneration
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 6, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 6, 2021
This was referenced Jul 6, 2021
Merged
Closed
tseaver pushed a commit that referenced this issue Jul 6, 2021
@daniellehanks
fix: populate etag / generation / metageneration properties during do…
49ba14c 
…wnload (#488)

Populate properties during download functions via Blob._extract_headers_from_download.

Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.

Closes #490.
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@daniellehanks @cojenco
fix: populate etag / generation / metageneration properties during do…
e8ca41d 
…wnload (googleapis#488)

Populate properties during download functions via Blob._extract_headers_from_download.

Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.

Closes googleapis#490.
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@daniellehanks @cojenco
fix: populate etag / generation / metageneration properties during do…
52d896c 
…wnload (googleapis#488)

Populate properties during download functions via Blob._extract_headers_from_download.

Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.

Closes googleapis#490.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@tseaver