Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate etag / generation / metageneration properties during download #488

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

daniellehanks
Copy link
Contributor

@daniellehanks daniellehanks commented Jul 6, 2021

Populates additional properties (etag, generation, metageneration) from the corresponding headers (ETag, x-goog-generation, and x-goog-metageneration) during download functions via Blob._extract_headers_from_download.

Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.

Closes #490.

@daniellehanks daniellehanks requested a review from a team July 6, 2021 00:30
@daniellehanks daniellehanks requested a review from a team as a code owner July 6, 2021 00:30
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2021
@tseaver tseaver changed the title Populate headers on download fix: populate etag / generation / metageneration properties during download Jul 6, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the patch!

CONTRIBUTING.rst Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2021
@tseaver tseaver merged commit 49ba14c into googleapis:master Jul 6, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 8, 2021
Support conditional requests based on ETag for read operations (`reload`, `exists`, `download_*`). My own testing seems to indicate that the JSON API does not support ETag If-Match/If-None-Match headers on modify requests (`patch`, `delete`, etc.), please correct me if I am mistaken.

This part two of #451. Part one in #488.
Fixes #451 🦕
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…wnload (googleapis#488)

Populate properties during download functions via Blob._extract_headers_from_download.

Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.

Closes googleapis#490.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Support conditional requests based on ETag for read operations (`reload`, `exists`, `download_*`). My own testing seems to indicate that the JSON API does not support ETag If-Match/If-None-Match headers on modify requests (`patch`, `delete`, etc.), please correct me if I am mistaken.

This part two of googleapis#451. Part one in googleapis#488.
Fixes googleapis#451 🦕
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…wnload (googleapis#488)

Populate properties during download functions via Blob._extract_headers_from_download.

Additionally, update documentation for running system tests to use Python 3.8 instead of Python 3.7 to align with nox.

Closes googleapis#490.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Support conditional requests based on ETag for read operations (`reload`, `exists`, `download_*`). My own testing seems to indicate that the JSON API does not support ETag If-Match/If-None-Match headers on modify requests (`patch`, `delete`, etc.), please correct me if I am mistaken.

This part two of googleapis#451. Part one in googleapis#488.
Fixes googleapis#451 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloads do not populate properties from all headers
3 participants