Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag built images as infrastructure for tooling purposes #660

Merged
merged 1 commit into from
Aug 13, 2024
+8 −0
Merged

fix: flag built images as infrastructure for tooling purposes #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,15 @@ steps:
"gcr.io/cloud-devrel-public-resources/storage-testbench:$TAG_NAME",
"gcr.io/cloud-devrel-public-resources/storage-testbench:latest",
]
- name: gcr.io/cloud-builders/docker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure but you may have to add waitFor since we are going to have multiple tags for this image now. For example: python-docker-image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this hasn't seemed to be necessary but I'll keep an eye on it with the next release, thank you Neha!

args:
[
"tag",
"gcr.io/cloud-devrel-public-resources/storage-testbench:$TAG_NAME",
"gcr.io/cloud-devrel-public-resources/storage-testbench:infrastructure-public-image-tb-latest",
]

images:
- gcr.io/cloud-devrel-public-resources/storage-testbench:$TAG_NAME
- gcr.io/cloud-devrel-public-resources/storage-testbench:latest
- gcr.io/cloud-devrel-public-resources/storage-testbench:infrastructure-public-image-tb-latest
Loading