fix: flag built images as infrastructure for tooling purposes #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojenco
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
lgtm based on b/351470247#comment6 internal-guide and what Neha linked in the team chat. Tagging @bajajneha27 for review, thanks!
cojenco
reviewed
Jul 31, 2024
There was a problem hiding this comment.
It seems like the 3.12 unit test is impacted by this codecov issue, which is currently being patched. Regardless we can merge the yaml file change
bajajneha27
reviewed
Aug 2, 2024
| @@ -25,7 +25,15 @@ steps: | |||
| "gcr.io/cloud-devrel-public-resources/storage-testbench:$TAG_NAME", | |||
| "gcr.io/cloud-devrel-public-resources/storage-testbench:latest", | |||
| ] | |||
| - name: gcr.io/cloud-builders/docker | |||
There was a problem hiding this comment.
I'm not 100% sure but you may have to add waitFor since we are going to have multiple tags for this image now. For example: python-docker-image
There was a problem hiding this comment.
So far this hasn't seemed to be necessary but I'll keep an eye on it with the next release, thank you Neha!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.