Arbitrary Counts and Lists Feature/CRD #2946

igooch · 2023-02-02T21:45:17Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Creates an alpha feature gate for the Arbitrary Counts and Lists feature that will eventually replace player tracking.
Adds Counts and Lists to the gamerserver, gamerserverset, and fleet CRDs.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

agones-bot · 2023-02-02T21:54:45Z

Build Failed 😱

Build Id: 90445c26-3a91-4093-aea8-07211ac5fa95

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-02T22:54:43Z

Build Failed 😱

Build Id: 2a35430e-d840-4cf3-bb71-11415301e95b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-02T23:59:12Z

Build Failed 😱

Build Id: cdffd5bd-d0b2-4e2b-b41c-edfb1f9bdd27

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-08T18:33:38Z

Build Succeeded 👏

Build Id: 4d7dee90-9543-4323-a4a2-c4c9a7d8cbee

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-8e3a4e8-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-8e3a4e8-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-8e3a4e8-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-8e3a4e8-amd64
Linux C++ SDK (build): agonessdk-1.30.0-8e3a4e8-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-8e3a4e8-amd64.zip

A preview of the website (the last 30 builds are retained):

https://8e3a4e8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2946/head:pr_2946 && git checkout pr_2946
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-8e3a4e8-amd64

agones-bot · 2023-02-08T20:55:31Z

Build Succeeded 👏

Build Id: c815d75f-3da8-4d95-a1e6-df3f7ee1fd9f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-26c11c3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-26c11c3-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-26c11c3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-26c11c3-amd64
Linux C++ SDK (build): agonessdk-1.30.0-26c11c3-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-26c11c3-amd64.zip

A preview of the website (the last 30 builds are retained):

https://26c11c3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2946/head:pr_2946 && git checkout pr_2946
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-26c11c3-amd64

install/helm/agones/templates/crds/_gameserverspecschema.yaml

install/helm/agones/templates/crds/_gameserverstatus.yaml

zmerlynn

The feature gate LGTM, left some comments on the CRD.

install/helm/agones/templates/crds/_gameserverspecschema.yaml

agones-bot · 2023-02-09T17:51:39Z

Build Failed 😱

Build Id: f5a7d38b-2043-4ea9-a5f7-2247c57606c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-09T19:01:21Z

Build Succeeded 👏

Build Id: 6b032e90-75ee-4df5-a6f3-5766d146a4d2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-eb3052b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-eb3052b-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-eb3052b-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-eb3052b-amd64
Linux C++ SDK (build): agonessdk-1.30.0-eb3052b-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-eb3052b-amd64.zip

A preview of the website (the last 30 builds are retained):

https://eb3052b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2946/head:pr_2946 && git checkout pr_2946
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-eb3052b-amd64

agones-bot · 2023-02-09T21:48:52Z

Build Succeeded 👏

Build Id: a565b2fb-80ee-48af-900d-e701b630ad78

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-171ed04-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-171ed04-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-171ed04-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-171ed04-amd64
Linux C++ SDK (build): agonessdk-1.30.0-171ed04-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-171ed04-amd64.zip

A preview of the website (the last 30 builds are retained):

https://171ed04-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2946/head:pr_2946 && git checkout pr_2946
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-171ed04-amd64

zmerlynn

LGTM. We can iterate under the feature gate after this.

google-oss-prow · 2023-02-09T22:07:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch, zmerlynn
Once this PR has been reviewed and has the lgtm label, please ask for approval from markmandel. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-02-09T22:57:04Z

Build Succeeded 👏

Build Id: d2c25544-e7ae-40bb-b746-6e6c4188f4c6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-6054cc3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-6054cc3-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-6054cc3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-6054cc3-amd64
Linux C++ SDK (build): agonessdk-1.30.0-6054cc3-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-6054cc3-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6054cc3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2946/head:pr_2946 && git checkout pr_2946
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6054cc3-amd64

markmandel

Sorry for the super late review, I should have looked at this when you asked - my apologies.

examples/gameserver.yaml

install/helm/agones/templates/crds/_gameserverspecschema.yaml

install/helm/agones/templates/crds/_gameserverstatus.yaml

install/helm/agones/templates/crds/fleet.yaml

install/helm/agones/templates/crds/gameserverset.yaml

google-oss-prow bot added do-not-merge/work-in-progress size/L labels Feb 2, 2023

google-oss-prow bot requested review from aLekSer and cyriltovena February 2, 2023 21:45

igooch force-pushed the arbitrary-counts-lists-2716 branch from e67c8ec to 82908e6 Compare February 2, 2023 22:45

igooch force-pushed the arbitrary-counts-lists-2716 branch from 82908e6 to 04ce028 Compare February 2, 2023 23:49

igooch force-pushed the arbitrary-counts-lists-2716 branch from 04ce028 to 8e3a4e8 Compare February 8, 2023 17:55

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8e3a4e8 to 26c11c3 Compare February 8, 2023 20:17

igooch marked this pull request as ready for review February 8, 2023 22:04

google-oss-prow bot removed the do-not-merge/work-in-progress label Feb 8, 2023

google-oss-prow bot requested review from dzlier-gcp and EricFortin February 8, 2023 22:04

roberthbailey assigned markmandel and gongmax Feb 8, 2023

zmerlynn reviewed Feb 9, 2023

View reviewed changes

install/helm/agones/templates/crds/_gameserverspecschema.yaml Show resolved Hide resolved

zmerlynn reviewed Feb 9, 2023

View reviewed changes

install/helm/agones/templates/crds/_gameserverstatus.yaml Outdated Show resolved Hide resolved

zmerlynn reviewed Feb 9, 2023

View reviewed changes

gongmax reviewed Feb 9, 2023

View reviewed changes

install/helm/agones/templates/crds/_gameserverspecschema.yaml Outdated Show resolved Hide resolved

install/helm/agones/templates/crds/_gameserverspecschema.yaml Outdated Show resolved Hide resolved

igooch added 4 commits February 9, 2023 14:05

Creates a feature gate for the arbitrary counts and lists feature

095f4d5

Adds counters and lists to gameserver CRD

9eb90e5

Updates naming counts to counters

db178cf

Updates comments in spec to clarify these are starting values

6054cc3

zmerlynn force-pushed the arbitrary-counts-lists-2716 branch from 171ed04 to 6054cc3 Compare February 9, 2023 22:05

gongmax approved these changes Feb 9, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Feb 9, 2023

zmerlynn approved these changes Feb 9, 2023

View reviewed changes

google-oss-prow bot assigned zmerlynn Feb 9, 2023

zmerlynn enabled auto-merge (squash) February 9, 2023 22:07

zmerlynn changed the title ~~Arbitrary counts lists 2716~~ Arbitrary Counts and Lists Feature/CRD Feb 9, 2023

zmerlynn merged commit 521fe47 into googleforgames:main Feb 9, 2023

markmandel reviewed Feb 10, 2023

View reviewed changes

igooch mentioned this pull request Feb 13, 2023

Updates counters lists schema status CRDs for gameservers fleets #2965

Merged

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arbitrary Counts and Lists Feature/CRD #2946

Arbitrary Counts and Lists Feature/CRD #2946

igooch commented Feb 2, 2023 •

edited

Loading

agones-bot commented Feb 2, 2023

agones-bot commented Feb 2, 2023

agones-bot commented Feb 2, 2023

agones-bot commented Feb 8, 2023

agones-bot commented Feb 8, 2023

zmerlynn left a comment

agones-bot commented Feb 9, 2023

agones-bot commented Feb 9, 2023

agones-bot commented Feb 9, 2023

zmerlynn left a comment

google-oss-prow bot commented Feb 9, 2023

agones-bot commented Feb 9, 2023

markmandel left a comment

Arbitrary Counts and Lists Feature/CRD #2946

Arbitrary Counts and Lists Feature/CRD #2946

Conversation

igooch commented Feb 2, 2023 • edited Loading

agones-bot commented Feb 2, 2023

agones-bot commented Feb 2, 2023

agones-bot commented Feb 2, 2023

agones-bot commented Feb 8, 2023

agones-bot commented Feb 8, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

agones-bot commented Feb 9, 2023

agones-bot commented Feb 9, 2023

agones-bot commented Feb 9, 2023

zmerlynn left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Feb 9, 2023

agones-bot commented Feb 9, 2023

markmandel left a comment

Choose a reason for hiding this comment

igooch commented Feb 2, 2023 •

edited

Loading