Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates counters lists schema status CRDs for gameservers fleets #2965

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Updates counters lists schema status CRDs for gameservers fleets #2965

merged 4 commits into from
Feb 16, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Feb 13, 2023 •
edited
Loading

Updates CRDs per comments on Arbitrary Counts and Lists Feature/CRD #2946.

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Updates schemas for Counts and Lists in the gamerserver, gamerserverset, and fleet CRDs.
Validates Counts and Lists in the gamerserver, gamerserverset, and fleet CRDs.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@igooch igooch mentioned this pull request Feb 13, 2023
Merged
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d2c3a625-848f-40d4-b2f7-4ecee2568c4d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2965/head:pr_2965 && git checkout pr_2965
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-bf9e785-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ccc34176-dda2-408e-a9db-ac01d9378bf0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from f568c8f to 3b93cab Compare February 13, 2023 20:56
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 36f4b124-e296-424d-acda-6c869c84ffce

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better! Some questions for you.

pkg/apis/agones/v1/gameserver.go Show resolved Hide resolved
examples/gameserver.yaml Outdated Show resolved Hide resolved
pkg/apis/agones/v1/gameserver.go Outdated Show resolved Hide resolved
pkg/apis/agones/v1/gameserver.go Show resolved Hide resolved
pkg/apis/agones/v1/gameserver.go Outdated Show resolved Hide resolved
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from b9f20f6 to c76d868 Compare February 15, 2023 21:58
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 94abae39-330f-4e2d-85d4-296a8a649170

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from c76d868 to 1757b18 Compare February 15, 2023 22:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 82d4007d-b6a7-4f49-bd9b-fe4f411ee81d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 1757b18 to 90a775e Compare February 15, 2023 22:06
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 265345e2-0c54-4bde-84e7-959ced6cbed8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 97e65191-0414-44cd-9f1e-d0876a0c4c46

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from fc58f8f to 92c4a00 Compare February 15, 2023 22:20
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c6cac446-01a0-4c41-9c6d-9e38f130af9d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 90ebe98b-48ad-4660-94b0-bf5574aece9f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 92c4a00 to 8767da8 Compare February 15, 2023 22:57
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 25f3f71f-449d-402c-9854-c08a241465ee

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 8767da8 to 3a00ce2 Compare February 16, 2023 17:19
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0ae011ee-34b9-4d57-981d-c8d0c0a6321b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from d85e0f8 to cb52a96 Compare February 16, 2023 17:32
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 68bf290e-e1c8-404b-a1ad-02df06e5dec8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2ad9d81e-213a-4b76-84f5-bc0ceeaa746b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from cb52a96 to b1d7a59 Compare February 16, 2023 17:48
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 88be0a52-d4b1-4eba-a6e6-03479fce7944

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Feb 16, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 81f98c37-33a4-462e-bf67-8c822051e8bf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 3bb4bb5 to ce9fd6f Compare February 16, 2023 20:19
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 734e1e74-2b27-4467-a643-d0fdde54a0d5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2965/head:pr_2965 && git checkout pr_2965
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-ce9fd6f-amd64

markmandel
markmandel approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@google-oss-prow google-oss-prow bot added the lgtm label Feb 16, 2023
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 16, 2023
@markmandel markmandel merged commit ce56e29 into googleforgames:main Feb 16, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax left review comments

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
5 participants
@igooch @agones-bot @markmandel @gongmax @Kalaiselvi84