Docs: remove unused specifications in cert-manager helm example

[qhyun2]

What type of PR is this?
/kind documentation

What this PR does / Why we need it:

These lines do not have any effect and can be removed since they are not referenced in the helm chart.

https://github.com/search?q=repo%3Agoogleforgames%2Fagones+path%3A%2F%5Einstall%5C%2Fhelm%5C%2Fagones%5C%2Ftemplates%5C%2F%2F+disableSecret&type=code

https://github.com/search?q=repo%3Agoogleforgames%2Fagones+path%3A%2F%5Einstall%5C%2Fhelm%5C%2Fagones%5C%2Ftemplates%5C%2F%2F+allocationApiService&type=code

https://github.com/search?q=repo%3Agoogleforgames%2Fagones+path%3A%2F%5Einstall%5C%2Fhelm%5C%2Fagones%5C%2Ftemplates%5C%2F%2F+validatingWebhook&type=code

https://github.com/search?q=repo%3Agoogleforgames%2Fagones+path%3A%2F%5Einstall%5C%2Fhelm%5C%2Fagones%5C%2Ftemplates%5C%2F%2F+mutatingWebhook&type=code

[agones-bot]

Build Succeeded 👏

Build Id: d1736800-741b-4b5c-b8b5-e05014e34a21

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.40.0-dev-5c2e964-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.40.0-dev-5c2e964-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.40.0-dev-5c2e964-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.40.0-dev-5c2e964-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.40.0-dev-5c2e964-amd64
• Linux C++ SDK (build): agonessdk-1.40.0-dev-5c2e964-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.40.0-dev-5c2e964-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://5c2e964-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3735/head:pr_3735 && git checkout pr_3735
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-5c2e964-amd64

[markmandel]

Blerg - this actually I think is a bug. From memory, we were supposed to move this helm parameters over to the new values in #2797, but it looks like we didn't.

@zmerlynn @gongmax - any thoughts on what we want to do here?

Should we add an issue to deprecate the agones.controller versions of these fields, and actually create the newer agones.extensions fields?

In helm, I wonder if we can set it up so that agones.controller values, if set, could overwrite the agones.extensions values?

Edit: We can use default and or empty function to default to agones.controller values if they are set: https://helm.sh/docs/chart_template_guide/function_list/

[markmandel]

Just making a note to self (or someone), we should turn this into an issue, and make the fixes.

[zmerlynn]

AIUI we're going to handle this via #3773 right?

[markmandel]

AIUI we're going to handle this via #3773 right?

Yes, good call. Thanks for bringing this to our attention @qhyun2 - but I'll close this for now, since we'll take this on at the above issue and PR.