React Native New Architecture support

[mrweiss]

Feature Request

React Native new architecture compatibility - is this a plan? what are the main reasons the package is not compatible?

Why it is needed

It's the direction React Native is going forward https://reactnative.dev/docs/the-new-architecture/landing-page

(https://reactnative.directory/?search=gorhom%2Fbottom-sheet)

Possible implementation

A technical assessment would have to be done to align with New Architecture requirements

Code sample

Not possible until technical assessment

[daves28]

The New Architecture is for Expo, not for React, but yes I agree a hugely popular library like this should consider becoming compatible.

[mrweiss]

The New Architecture is for Expo, not for React, but yes I agree a hugely popular library like this should consider becoming compatible.

sorry my bad! changed the title to React Native New Architecture :) not just Expo, though!

[iliapnmrv]

Hey! This library does not have any native part so it does support New Architecture by default. I've just created a new app with new architecture and rn-bottom-sheet works fine for me

[daves28]

That makes sense. This site is incorrectly reporting that this library is incompatible then https://reactnative.directory/?search=bottom-sheet

[iliapnmrv]

react-native-community/directory#1198 this pr set value to false
@0xFA11 Hey! Are you sure this library does not support New Architecture?

[0xFA11]

I didn't test recently but I'd say please use this thread for proper testing on v5: #1823

Attempted fix didn't really fix it for me in the past (I still had issues with Expo51 + Reanimated3 + bottom sheet scrollview).

I'd suggest testing v5 thoroughly with all components, including bottomsheet scrollview etc and potentially using a simple reanimated3 based view with bottomsheet's exposed animIndex somewhere too.

other than that, if everything looks good then let's call it newArch-supported.

[mateoabrbt]

I just try it out it seems i little bit buggy even with v5 sometime the modal would just not open i'm gonna try to see what could cause that.

[qnrjs42]

I just try it out it seems i little bit buggy even with v5 sometime the modal would just not open i'm gonna try to see what could cause that.

same.

[bahadiraraz]

Based on my testing results, bottom sheets are not functioning correctly in v5 when using React Native's new architecture - they simply don't open. While bottom sheet v4 is still working, it generates multiple console warnings during operation. The issue appears to be specifically related to the bottom sheet animation and mounting behavior in conjunction with the new architecture.

[mateoabrbt]

I would add that i create a custom component passing multiple children inside it and it simply didn't open but using a more simple approach works. It wasn't working for me on V4 also. I would suggest to try out the present method for opening the modal on new architecture.

[gorhom]

the library been tested on new arch and it is working , feel free to cut a another ticket if you discover new issues

[the-simian]

@gorhom I still get

The following issues were found when validating your dependencies against React Native Directory:
Unsupported on New Architecture: @gorhom/bottom-sheet

with expo-doctor@latest,
do we need to update https://reactnative.directory/?search=bottom-sheet to say its compatible now?

edit: I've made a PR to update it react-native-community/directory#1340 so it reflects your testing